Use amrex::getParticleCell More
#5557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One leftover occurance in `ParticleReductionFunctor`.
This was referenced Jan 14, 2025
archermarx
reviewed
Jan 14, 2025
|
I think the comment by @hklion (cc @atmyers) is to use an actual interpolation instead of assigning to a cell index. NGP (next-grid-cell) interpolation and just assigning to the cell a particle is in differs slightly. But in the end, if we use interpolation we probably would like to use at least CIC (cloud-in-cell) for clean results and charge conservation (where needed for analysis in respect to currents). |
|
Gotcha, thanks! |
roelof-groenewald
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One leftover occurance in
ParticleReductionFunctor.Follow-up to #5118